-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.2 #561
Release v0.2 #561
Conversation
* Replace `for_particle_neighbor` * Change kwarg `particles` to `points` * Remove `create_neighborhood_search` * Fix examples and tests * Reintroduce `create_neighborhood_search` to allow `nothing` * Restrict PointNeighbors.jl version * Fix tests * Fix tests * Fix examples * Fix validation * Fix docs * Mention periodic boxes in the docs * Fix tests * Fix tests
* Prepare Release 0.2 * Set Version Number * Change wording * Change formatting * Review comment Co-authored-by: Erik Faulhaber <[email protected]> * Formatting --------- Co-authored-by: Erik Faulhaber <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #561 +/- ##
==========================================
- Coverage 69.80% 69.72% -0.09%
==========================================
Files 75 75
Lines 4573 4551 -22
==========================================
- Hits 3192 3173 -19
+ Misses 1381 1378 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* Use PointNeighbors v0.4 * Apply new changes * Fix docs * Update validation files The new version of PointNeighbors.jl changed the particles ordering in the neighborhood search. * Why did this file change again? * Update WCSPH validation files due to viscosity reformulation * Update validation files on a single thread * Increase tolerances for Julia 1.9
# Initialize this system | ||
initialize!(system, neighborhood_search) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was confused why we pass neighborood_search
here.
This is a system initialization and the only initialized system here is the tlsph system.
The nhs is initialized above, so can we change this to initialize!(system)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or better initialize!(system, semi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a neighborhood search to initialize the TLSPH system (compute correction matrix and stuff).
And passing the neighborhood search is more convenient than passing the semidiscretization when writing benchmarks in PointNeighbors.jl, where we don't necessarily have a semidiscretization.
Waiting on breaking changes in trixi-framework/PointNeighbors.jl#42.
Based on #562.